Sprint12 staging #494
Sprint12 staging #494
Conversation
- Enabled 'Select All' to toggle all profiles; - Code clean up
Co-authored-by: Kevin Day <[email protected]>
Profile summary feature fix
profile summary download feature
…ile Summary component - Refactored and cleaned up code - Fixed issue where selected profiles could not be downloaded by sanitizing exportName (trim only, no lowercase conversion)
Sprint12 staging filename fix
…ent needs revisit
…rt-section-people
Updated the dependency version for scholars-embed-utilities.
#498 - Code clean up.
Co-authored-by: tamu-sad-iii <[email protected]>
470 export section people
| return this.labelSubject.asObservable(); | ||
| } | ||
|
|
||
| public get selectedPeople() : Observable<any[]> { |
There was a problem hiding this comment.
This should be an observable in an immutable feature store and observed from the store.
An action should be dispatched to make selection and download.
There was a problem hiding this comment.
Actually, are these even required in this component anymore? I don't think so.
There was a problem hiding this comment.
Created note to incorporate the suggestion:
Scholars@TAMU (view)
|
|
||
| private subscriptions: Subscription[]; | ||
|
|
||
| public selectedOrganization: Observable<Individual>; |
There was a problem hiding this comment.
If following NGRX design patterns, selectedOrganization and selectedPeople should be an observable in an immutable feature store and observed from the store.
An action should be dispatched to make selection and download.
There was a problem hiding this comment.
Created note to incorporate the suggestion:
Scholars@TAMU (view)
Description
Resolves #470
Resolves #480
Resolves #496
Type of change
Testing Procedures
Tested these features on local set up
Verified the same on DEV environment.